Re: [PATCH 3/4] KVM: X86: Handle implicit supervisor access with SMAP

[Paolo Bonzini]

On 12/7/21 22:52, Sean Christopherson wrote:
> > -	unsigned long not_smap = (cpl - 3) & (rflags & X86_EFLAGS_AC);
> > +	u32 not_smap = (rflags & X86_EFLAGS_AC) & vcpu->arch.explicit_access;
> I really, really dislike shoving this into vcpu->arch.  I'd much prefer to make
> this a property of the access, even if that means adding another param or doing
> something gross with @access (@pfec here).

Well, we already have something gross going on with the pfec.  Maybe we 
should add separate constants for the index into mmu->permissions.

Paolo