Re: [PATCH] cifs: Fix crash on unload of cifs_arc4.ko

[Steve French]

merged into cifs-2.6.git for-next

On Tue, Dec 7, 2021 at 6:11 AM Vincent Whitchurch via samba-technical
<samba-technical@xxxxxxxxxxxxxxx> wrote:
>
> The exit function is wrongly placed in the __init section and this leads
> to a crash when the module is unloaded.  Just remove both the init and
> exit functions since this module does not need them.
>
> Fixes: 71c02863246167b3d ("cifs: fork arc4 and create a separate module...")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> ---
>  fs/smbfs_common/cifs_arc4.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/fs/smbfs_common/cifs_arc4.c b/fs/smbfs_common/cifs_arc4.c
> index 85ba15a60b13..043e4cb839fa 100644
> --- a/fs/smbfs_common/cifs_arc4.c
> +++ b/fs/smbfs_common/cifs_arc4.c
> @@ -72,16 +72,3 @@ void cifs_arc4_crypt(struct arc4_ctx *ctx, u8 *out, const u8 *in, unsigned int l
>         ctx->y = y;
>  }
>  EXPORT_SYMBOL_GPL(cifs_arc4_crypt);
> -
> -static int __init
> -init_smbfs_common(void)
> -{
> -       return 0;
> -}
> -static void __init
> -exit_smbfs_common(void)
> -{
> -}
> -
> -module_init(init_smbfs_common)
> -module_exit(exit_smbfs_common)
> --
> 2.33.1
>
>


-- 
Thanks,

Steve