Re: [PATCH -V10 RESEND 1/6] NUMA Balancing: add page promotion counter

From: Huang, Ying
Date: Tue Dec 07 2021 - 21:16:23 EST


Hasan Al Maruf <hasan3050@xxxxxxxxx> writes:

> Hi Huang,
>
>>+#ifdef CONFIG_NUMA_BALANCING
>>+ PGPROMOTE_SUCCESS, /* promote successfully */
>
> I find a breakdown of Anon and File page promotion can often be useful to
> understand an application's behavior (i.e. what kind of pages are moved to
> remote node and later being promoted). What do you think about adding
> counters for such a breakdown?
>
> What's your thought on adding counters for failures on different reasons?

I think that all these provide helpful information. But I think that we
can add them in separate patches. That will make reviewing simpler.

Best Regards,
Huang, Ying