Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification

From: Kees Cook
Date: Tue Dec 07 2021 - 17:02:47 EST


On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote:
> From: Rae Moar <rmoar@xxxxxxxxxx>
>
> It does not make any significant additions or changes other than those
> already in use in the kernel: additional features can be added as they
> become necessary and used.
>
> [1]: https://testanything.org/tap-version-13-specification.html
>
> Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx>
> Co-developed-by: David Gow <davidgow@xxxxxxxxxx>
> Signed-off-by: David Gow <davidgow@xxxxxxxxxx>

I like it! Thank you so much for suffering through my earlier reviews.
:)

The only concern I have is wonder what'll be needed to kselftest to
deal with indentation changes. As long as this can be implemented
without a subtest knowing it is a subtest, we're good.

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook