RE: [PATCH v5 09/10] ARM: sunplus: Add initial support for Sunplus SP7021 SoC

[qinjian[覃健]]

> > +config ARCH_SUNPLUS
> > +       bool "Sunplus SoCs"
> > +       select CLKSRC_OF
> > +       select COMMON_CLK
> > +       select GENERIC_CLOCKEVENTS
> > +       select GENERIC_IRQ_CHIP
> > +       select GENERIC_IRQ_MULTI_HANDLER
> > +       select USE_OF
> > +       select RTC_CLASS
> > +       select RESET_SUNPLUS
> 
> This is in the wrong place: move the Kconfig entry into
> arch/arm/mach-sunplus/Kconfig
> and make it 'depends on ARCH_MULTI_V7'.
> 
> I think you can remove all the 'select' lines as well because they are
> either implied by
> ARCH_MULTI_V7 or not actually necessary.
> ......

Thanks for your review, I'll correct these at next commit.

> 
> > @@ -152,6 +152,7 @@ textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> >  textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> >  textofs-$(CONFIG_ARCH_MESON) := 0x00208000
> >  textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
> > +textofs-$(CONFIG_ARCH_SUNPLUS) := 0x00308000
> 
> What is this needed for? If it boots without this line, better avoid
> adding it, because
> it will increase the kernel size for everyone else (unless they also enable
> AXXIA).
> 

SP7021 reserved the 1st 1MB memory for ARM926@P-Chip using,
The 2nd 1MB memory for IOP device and the 3rd 1MB memory for bootloader.
I'll add these comments at next commit.