Re: [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret"

[huangguangbin (A)]

On 2021/12/7 8:34, Jakub Kicinski wrote:
> On Sun, 5 Dec 2021 14:18:21 +0200 Leon Romanovsky wrote:
> > On Sun, Dec 05, 2021 at 01:51:37PM +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@xxxxxxxxxx>
> > >
> > > There are two issues with this patch:
> > > 1. devlink_register() doesn't return any value. It is already void.
> > > 2. It is not kernel coding at all to cast return type to void.
> > >
> > > This reverts commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6.
> > >
> > > Link: https://lore.kernel.org/all/Yan8VDXC0BtBRVGz@unreal
> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> > > ---
> > >   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
> > >   drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
> > >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > It was already sent, but not merged yet.
> > https://lore.kernel.org/all/20211204012448.51360-1-huangguangbin2@xxxxxxxxxx
>
> Indeed, Guangbin in the future please make sure to CC the person whose
> feedback the patches are based on.
> .
Ok.