Re: [RFC PATCH 19/19] drivers: android: Binder IPC in Rust

From: Greg Kroah-Hartman
Date: Mon Dec 06 2021 - 11:05:09 EST


On Mon, Dec 06, 2021 at 03:59:46PM +0000, Wedson Almeida Filho wrote:
> On Mon, Dec 06, 2021 at 04:01:15PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 06, 2021 at 03:03:13PM +0100, Miguel Ojeda wrote:
> > > From: Wedson Almeida Filho <wedsonaf@xxxxxxxxxx>
> > >
> > > A port to Rust of the Android Binder IPC mechanism.
> > >
> > > This module is a work in progress and will be sent for review later
> > > on, as well as separately from the Rust support.
> > >
> > > However, it is included to show how an actual working module
> > > written in Rust may look like.
> >
> > Have you all tested this against the userspace binder tests? And is it
> > up to date with the features of the in-kernel binder driver?
>
> Very little has changed here since the last submission, namely: using
> credentials for security callbacks, and replacing `Arc` with `Ref` (i.e., using
> refcount_t to manage ref-counted allocations).
>
> As the message tries to indicate, this is submitted as an example and WIP, it
> doesn't have feature parity with the C version yet.

You might want to say that in the changelog text so I don't keep asking
every time it gets posted :)

thanks,

greg k-h