Re: [PATCH v2] driver: pmc_atom: free pmc->regmap when pmc_setup_clks fails

[Andy Shevchenko]

On Mon, Dec 06, 2021 at 04:00:13PM +0200, Andy Shevchenko wrote:
> On Sun, Dec 05, 2021 at 04:44:19PM +0800, Dongliang Mu wrote:
> > Smatch reports:
> > 
> > drivers/platform/x86/pmc_atom.c:496
> > pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> > 
> > Fix this by deallocating pm->regmap when pmc_setup_clks fails.
> > 
> > Fixes: 282a4e4ce5f9("platform/x86: Enable Atom PMC platform clocks")
> > Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> > ---
> 
> It says v2 in the subject, what is in v2 exactly in comparison to v1?
> 
> ...
> 
> >  	ret = pmc_setup_clks(pdev, pmc->regmap, data);
> > -	if (ret)
> > +	if (ret) {
> > +		iounmap(pmc->regmap);
> >  		dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
> >  			 ret);
> 
> In this case it makes sense to move to
> 
> 		dev_err(&pdev->dev, "platform clocks register failed: %d\n", ret);
> 
> > +	}

Also, what about cleaning up debugfs?

-- 
With Best Regards,
Andy Shevchenko