RE: [PATCH] iwlwifi: mei: allow tracing to be disabled

From: Grumbach, Emmanuel
Date: Sun Dec 05 2021 - 13:12:55 EST


> Subject: [PATCH] iwlwifi: mei: allow tracing to be disabled
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The Makefile conditionally leaves out the trace implementation, but it gets
> called unconditionally:
>
> ERROR: modpost: "__SCT__tp_func_iwlmei_me_msg"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_me_msg"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__SCT__tp_func_iwlmei_sap_cmd"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_sap_cmd"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__SCT__tp_func_iwlmei_sap_data"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_sap_data"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
>
> Use the same macro incantation that is used in the main iwlwifi driver to
> leave out the tracing when CONFIG_IWLWIFI_DEVICE_TRACING is disabled.
>
> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with
> CSME")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for this, but Kalle just merged a fix I had already sent.