Re: [PATCH V8 06/14] rtla: Add timerlat tool and timelart top mode

From: Daniel Bristot de Oliveira
Date: Fri Dec 03 2021 - 12:41:50 EST


On 12/3/21 10:13, Tao Zhou wrote:
>> +/*
>> + * timerlat_top_usage - prints timerlat top usage message
>> + */
>> +static void timerlat_top_usage(char *usage)
>> +{
>> + int i;
>> +
>> + static const char *const msg[] = {
>> + "",
>> + " usage: rtla timerlat [top] [-h] [-q] [-p us] [-i us] [-t us] [-s us] [-T[=file]] \\",
>> + " [-c cpu-list] [-P priority]",
>> + "",
>> + " -h/--help: print this menu",
>> + " -p/--period us: timerlat period in us",
>> + " -i/--irq us: stop trace if the irq latency is higher than the argument in us",
>> + " -T/--thread us: stop trace if the thread latency is higher than the argument in us",
>> + " -s/--stack us: save the stack trace at the IRQ if a thread latency is higher than the argument in us",
>> + " -c/--cpus cpus: run the tracer only on the given cpus -d/--duration time[m|h|d]: duration of the session in seconds",
>> + " -t/--trace[=file]: save the stopped trace to [file|timerlat_trace.txt]",
>> + " -n/--nano: display data in nanoseconds",
>> + " -q/--quiet print only a summary at the end",
>> + " -P/--priority o:prio|r:prio|f:prio|d:runtime:period : set scheduling parameters",
>> + " o:prio - use SCHED_OTHER with prio",
>> + " r:prio - use SCHED_RR with prio",
>> + " f:prio - use SCHED_FIFO with prio",
>> + " d:runtime[us|ms|s]:period[us|ms|s] - use SCHED_DEADLINE with runtime and period",
>> + " in nanoseconds",
>> + NULL,
>> + };
> About help usage msg.
>
> [-t us] --> [-T us]
> [-T=[file]] --> [-t[=file]]
>
> [-d] [-D] [-n] lack in the head usage info 'usage: ...'
>

Fixed in V9

-- Daniel