Re: [PATCH v4 1/4] mfd: da9062: make register CONFIG_I writable

[Guenter Roeck]

On 12/3/21 12:59 AM, Andrej Picej wrote:
> On 2. 12. 21 16:18, Christoph Niedermaier wrote:
> > From: Andrej Picej
> > Sent: Thursday, December 2, 2021 10:32 AM
> > > From: Stefan Christ <s.christ@xxxxxxxxx>
> > >
> > > Make the config register CONFIG_I writable to change the watchdog mode.
> > >
> > > Signed-off-by: Stefan Christ <s.christ@xxxxxxxxx>
> > > Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx>
> > > ---
> > > Chnages in v4:
> > >   - no changes
> > >
> > > Changes in v3:
> > >   - no chagnes
> > >
> > > Changes in v2:
> > >   - no changes
> > > ---
> > >   drivers/mfd/da9062-core.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> > > index 01f8e10dfa55..7041ba53efb4 100644
> > > --- a/drivers/mfd/da9062-core.c
> > > +++ b/drivers/mfd/da9062-core.c
> > > @@ -556,6 +556,7 @@ static const struct regmap_range
> > > da9062_aa_writeable_ranges[] = {
> > >          regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
> > >          regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
> > >          regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT),
> > > +       regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I),
> > >          regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
> > >   };
>
> > Could you also include the CONFIG_I for the DA9061?
> > So I can test it on my system.
>
> Yes, I don't see the problem here.
> @Maintainers, should I send a new version with this (then I would also fix the minor spelling mistake in commit message of 2/4), or do you prefer a separate patch?

Either way is fine, with a slight preference on sending a new version.

Guenter