Re: [PATCH] arm64: dts: ti: k3-am642: Fix the L2 cache sets

From: Pratyush Yadav
Date: Fri Dec 03 2021 - 06:13:22 EST


On 12/11/21 10:36PM, Nishanth Menon wrote:
> A53's L2 cache[1] on AM642[2] is 256KB. A53's L2 is fixed line length
> of 64 bytes and 16-way set-associative cache structure.

This time the commit message is correct :-)

Reviewed-by: Pratyush Yadav <p.yadav@xxxxxx>

>
> 256KB of L2 / 64 (line length) = 4096 ways
> 4096 ways / 16 = 256 sets
>
> Fix the l2 cache-sets.
>
> [1] https://developer.arm.com/documentation/ddi0500/j/Level-2-Memory-System/About-the-L2-memory-system?lang=en
> [2] https://www.ti.com/lit/pdf/spruim2
>
> Fixes: 8abae9389bdb ("arm64: dts: ti: Add support for AM642 SoC")
> Reported-by: Peng Fan <peng.fan@xxxxxxx>
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---
> arch/arm64/boot/dts/ti/k3-am642.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642.dtsi b/arch/arm64/boot/dts/ti/k3-am642.dtsi
> index e2b397c88401..8a76f4821b11 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am642.dtsi
> @@ -60,6 +60,6 @@ L2_0: l2-cache0 {
> cache-level = <2>;
> cache-size = <0x40000>;
> cache-line-size = <64>;
> - cache-sets = <512>;
> + cache-sets = <256>;
> };
> };

--
Regards,
Pratyush Yadav
Texas Instruments Inc.