RE: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime features

[Ronak Jain]

Hi Greg,

Thanks for reviewing the patch.

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, December 3, 2021 2:55 PM
> To: Ronak Jain <ronakj@xxxxxxxxxx>
> Cc: Michal Simek <michals@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Rajan
> Vaja <RAJANV@xxxxxxxxxx>; corbet@xxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; Sai Krishna Potthuri
> <lakshmis@xxxxxxxxxx>
> Subject: Re: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime
> features
> 
> On Fri, Dec 03, 2021 at 01:18:13AM -0800, Ronak Jain wrote:
> > Create sysfs entry for runtime feature configuration. The support  is
> > added for an over temperature and external watchdog feature.
> >
> > The below listed files are used for runtime features configuration:
> > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
> > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
> >
> > In order to configure an over temperature or external watchdog
> > features, first the user need to select the valid config id and then
> > the user can configure the value for selected feature config id.
> >
> > Signed-off-by: Ronak Jain <ronak.jain@xxxxxxxxxx>
> 
> Ah, here's the documentation.
> 
> You should say so in the Subject line, and the changelog text is not correct, this
> is a documentation update.
I will fix the suggested changes.

> 
> 
> > ---
> > Changes in v3:
> > - None
> >
> > Changes in v2:
> > - Update commit message
> > ---
> >  .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > index f5724bb5b462..2fde354715a5 100644
> > --- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > +++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > @@ -113,3 +113,87 @@ Description:
> >  		    # echo 0 >
> > /sys/devices/platform/firmware\:zynqmp-firmware/health_status
> >
> >  Users:		Xilinx
> > +
> > +What:		/sys/devices/platform/firmware\:zynqmp-
> firmware/feature_config_*
> > +Date:		Aug 2021
> > +KernelVersion:	5.14
> 
> 5.14?
Will fix it.
> 
> Are these sysfs files already in the kernel tree?
No
> 
> And can you break this up into one entry per sysfs file?
> 
> One for the feature_config_id file and one for feature_config_value?
Yes, I will make a separate documentation for the sysfs files.

Thanks,
Ronak
> 
> thanks,
> 
> greg k-h