Re: [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

From: Stephen Boyd
Date: Thu Dec 02 2021 - 17:51:44 EST


Quoting Stephen Boyd (2021-09-14 12:49:13)
> Quoting Kuogee Hsieh (2021-09-14 09:45:01)
> > Both voltage and pre-emphasis swing level are set during link training
> > negotiation between host and sink. There are totally four tables added.
> > A voltage swing table for both hbr and hbr1, a voltage table for both
> > hbr2 and hbr3, a pre-emphasis table for both hbr and hbr1 and a pre-emphasis
> > table for both hbr2 and hbr3. In addition, write 0x0a to TX_TX_POL_INV is
> > added to complete the sequence of configure dp phy base on HPG.
> >
> > Chnages in v2:
> > -- revise commit test
> > -- add Fixes tag
> > -- replaced voltage_swing_cfg with voltage
> > -- replaced pre_emphasis_cfg with emphasis
> > -- delete drv_lvl_reg and emp_post_reg parameters from qcom_qmp_v4_phy_configure_dp_swing()
> > -- delete drv_lvl_reg and emp_post_reg parameters from qcom_qmp_phy_configure_dp_swing()
> >
> > Changes in V3:
> > -- add __qcom_qmp_phy_configure_dp_swing() to commit swing/pre-emphasis level
> >
> > Changes in V4:
> > -- pass 2D array to __qcom_qmp_phy_configure_dp_swing()
> >
> > Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy")
> > Signed-off-by: Kuogee Hsieh <khsieh@xxxxxxxxxxxxxx>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Can this patch be picked up?