Re: [PATCH v1 1/1] net: dsa: vsc73xxx: Get rid of duplicate of_node assignment

[Vladimir Oltean]

On Thu, Dec 02, 2021 at 11:00:29PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
> 
> For the details one may look into the of_gpio_dev_init() implementation.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/net/dsa/vitesse-vsc73xx-core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c
> index 4c18f619ec02..ae55167ce0a6 100644
> --- a/drivers/net/dsa/vitesse-vsc73xx-core.c
> +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c
> @@ -1122,9 +1122,6 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc)
>  	vsc->gc.ngpio = 4;
>  	vsc->gc.owner = THIS_MODULE;
>  	vsc->gc.parent = vsc->dev;
> -#if IS_ENABLED(CONFIG_OF_GPIO)
> -	vsc->gc.of_node = vsc->dev->of_node;
> -#endif
>  	vsc->gc.base = -1;
>  	vsc->gc.get = vsc73xx_gpio_get;
>  	vsc->gc.set = vsc73xx_gpio_set;
> -- 
> 2.33.0
> 

I'm in To: and everyone else is in Cc? I don't even have the hardware.
Adding Linus just in case, although the change seems correct.

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>