Re: [PATCH net-next] net: prestera: flower template support

From: Jamal Hadi Salim
Date: Thu Dec 02 2021 - 12:26:08 EST


On 2021-12-02 10:50, Volodymyr Mytnyk wrote:
From: Volodymyr Mytnyk<vmytnyk@xxxxxxxxxxx>

Add user template explicit support. At this moment, max
TCAM rule size is utilized for all rules, doesn't matter
which and how much flower matches are provided by user. It
means that some of TCAM space is wasted, which impacts
the number of filters that can be offloaded.

Introducing the template, allows to have more HW offloaded
filters.

Example:
tc qd add dev PORT clsact
tc chain add dev PORT ingress protocol ip \
flower dst_ip 0.0.0.0/16

"chain" or "filter"?

tc filter add dev PORT ingress protocol ip \
flower skip_sw dst_ip 1.2.3.4/16 action drop

You are not using tc priority? Above will result in two priorities
(the 0.0.0.0 entry will be more important) and in classical flower
approach two different tables.
I am wondering how you map the table to the TCAM.
Is the priority sorting entirely based on masks in hardware?

cheers,
jamal