Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

From: Geert Uytterhoeven
Date: Thu Dec 02 2021 - 05:05:17 EST


Hi Rob,

On Wed, Dec 1, 2021 at 11:44 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> > To improve human readability and enable automatic validation, the tuples
> > in "snps,block-size" and "snps,priority" properties should be grouped
> > using angle brackets.
>
> For these, the tools should allow either way. Where are you seeing an
> error?

Good to know. I'm not seeing any errors.

> I tried to rationalize which way should be 'correct' and gave up. I
> think bracketing only makes sense for matrix and phandle+arg cases.

That makes sense. And "interrupts" is special, because it's really a
short-hand for "interrupts-extended", with the phandle specified by
"interrupt-parent" at the same or a higher level.

Hence I'll drop this patch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds