Re: [PATCH] ata: replace snprintf in show functions with sysfs_emit

[Damien Le Moal]

On 2021/11/30 9:04, davidcomponentone@xxxxxxxxx wrote:
> From: Yang Guang <yang.guang5@xxxxxxxxxx>
> 
> coccinelle report：
> ./drivers/ata/libata-sata.c:830:8-16: 
> WARNING: use scnprintf or sprintf
> 
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Yang Guang <yang.guang5@xxxxxxxxxx>
> ---
>  drivers/ata/libata-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
> index 5b78e86e3459..b9c77885b872 100644
> --- a/drivers/ata/libata-sata.c
> +++ b/drivers/ata/libata-sata.c
> @@ -827,7 +827,7 @@ static ssize_t ata_scsi_lpm_show(struct device *dev,
>  	if (ap->target_lpm_policy >= ARRAY_SIZE(ata_lpm_policy_names))
>  		return -EINVAL;
>  
> -	return snprintf(buf, PAGE_SIZE, "%s\n",
> +	return sysfs_emit(buf, "%s\n",
>  			ata_lpm_policy_names[ap->target_lpm_policy]);
>  }
>  DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
> 

Applied to for-5.16-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research