Re: [PATCH v4] KEYS: trusted: Fix trusted key backends when building as module

From: Jarkko Sakkinen
Date: Wed Dec 01 2021 - 05:40:12 EST


On Wed, Dec 01, 2021 at 10:59:00AM +0100, Ahmad Fatoum wrote:
> From: Andreas Rammhold <andreas@xxxxxxxxxxx>
>
> Before this commit the kernel could end up with no trusted key sources
> even though both of the currently supported backends (TPM and TEE) were
> compiled as modules. This manifested in the trusted key type not being
> registered at all.
>
> When checking if a CONFIG_… preprocessor variable is defined we only
> test for the builtin (=y) case and not the module (=m) case. By using
> the IS_REACHABLE() macro we do test for both cases.
>
> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
> Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> Reviewed-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
> Signed-off-by: Andreas Rammhold <andreas@xxxxxxxxxxx>
> Tested-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>

Thank you, I picked this.

/Jarkko