RE: [PATCH v2 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong length issue

[Neal Liu]

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, November 30, 2021 7:47 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew
> Jeffery <andrew@xxxxxxxx>; Cai Huoqing <caihuoqing@xxxxxxxxx>; Tao Ren
> <rentao.bupt@xxxxxxxxx>; Julia Lawall <julia.lawall@xxxxxxxx>; kernel test
> robot <lkp@xxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>;
> linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; BMC-SW
> <BMC-SW@xxxxxxxxxxxxxx>; Benjamin Herrenschmidt
> <benh@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong
> length issue
> 
> On Tue, Nov 30, 2021 at 06:42:55PM +0800, Neal Liu wrote:
> > If multiple devices in vhub are enumerated simultaneously, ep0 OUT ack
> > might received wrong data length. Using expected data length instead.
> >
> > Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
> > b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
> > index 74ea36c19b1e..bea9cbb191a2 100644
> > --- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
> > +++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
> > @@ -251,6 +251,13 @@ static void ast_vhub_ep0_do_receive(struct
> ast_vhub_ep *ep, struct ast_vhub_req
> >  		len = remain;
> >  		rc = -EOVERFLOW;
> >  	}
> > +
> > +	/* HW return wrong data len */
> 
> Please spell out "Hardware"?
> 
> thanks,
> 
> greg k-h

Sure, I'll fix it in next patch.
Thanks

Best Regards,
-Neal