RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

[Neal Liu]

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, November 30, 2021 7:43 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew
> Jeffery <andrew@xxxxxxxx>; Cai Huoqing <caihuoqing@xxxxxxxxx>; Tao Ren
> <rentao.bupt@xxxxxxxxx>; Julia Lawall <julia.lawall@xxxxxxxx>; kernel test
> robot <lkp@xxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>;
> linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx;
> benh@xxxxxxxxxxxxxxxxxxx; BMC-SW <BMC-SW@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
> 
> On Tue, Nov 30, 2021 at 07:38:44PM +0800, Neal Liu wrote:
> > +Ben.
> > ---
> >
> > Support qualifier descriptor to pass USB30CV compliance test.
> >
> > Signed-off-by: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> > ---
> 
> The way you wrote this means that everything below the first --- line will be cut
> off if it were to be applied.
> 
> That is not what you want.
> 
> Please fix.
> 
> thanks,
> 
> greg k-h

Yes, I'll fix it. Thanks

-Neal