Re: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.

From: Andrew Lunn
Date: Tue Nov 30 2021 - 20:56:45 EST


> + nvmem-cells:
> + items:
> + - description: nvmem cell address of MAC address of 1st MAC
> + - description: nvmem cell address of MAC address of 2nd MAC
> +
> + nvmem-cell-names:
> + description: names corresponding to the nvmem cells of MAC address
> + items:
> + - const: mac_addr0
> + - const: mac_addr1

These are port properties, so put them in the port section.

Also, the name you should use is well defined, "mac-address". See
nvmem_get_mac_address(). But you won't be able to use that helper
because it take dev, not an of node.

Andrew