Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work

From: Baolin Wang
Date: Mon Nov 29 2021 - 20:40:54 EST


Hi,

On 2021/11/29 21:38, Zhenguo Yao wrote:
Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b
(hugetlbfs: extend the definition of hugepages parameter to support node
allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will
always return without doing allocation. Fix this by adding more check.

Signed-off-by: Zhenguo Yao <yaozhenguo1@xxxxxxxxx>

You should add a fixes tag, otherwise LGTM.
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")