Re: [PATCH 4/9] drivers: Switch to kvfree_rcu() API

From: Uladzislau Rezki
Date: Mon Nov 29 2021 - 13:54:21 EST


On Mon, Nov 29, 2021 at 1:58 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> On Wed, 24 Nov 2021, Uladzislau Rezki (Sony) wrote:
>
> > Instead of invoking a synchronize_rcu() to free a pointer
> > after a grace period we can directly make use of new API
> > that does the same but in more efficient way.
> >
> > CC: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> > CC: "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>
> > CC: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > CC: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>
> > CC: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> > CC: Lee Jones <lee.jones@xxxxxxxxxx>
> > CC: Jorgen Hansen <jhansen@xxxxxxxxxx>
> > CC: Raju Rangoju <rajur@xxxxxxxxxxx>
> > CC: Saeed Mahameed <saeedm@xxxxxxxxxx>
> > CC: Boris Pismenny <borisp@xxxxxxxxxx>
> > CC: Jiri Pirko <jiri@xxxxxxxxxx>
> > CC: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> > ---
> > drivers/block/drbd/drbd_nl.c | 9 +++------
> > drivers/block/drbd/drbd_receiver.c | 6 ++----
> > drivers/block/drbd/drbd_state.c | 3 +--
> > drivers/block/rnbd/rnbd-srv.c | 3 +--
> > drivers/crypto/nx/nx-common-pseries.c | 3 +--
> > drivers/infiniband/hw/hfi1/sdma.c | 3 +--
> > drivers/ipack/carriers/tpci200.c | 3 +--
>
> > drivers/mfd/dln2.c | 6 ++----
>
> I'm not an expert in this API, but the premise and changes to MFD seem
> fine at first glance:
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
Thanks!

--
Uladzislau Rezki