Re: [PATCH v3 0/3] Add bindings for peripheral-specific SPI controller properties

From: Pratyush Yadav
Date: Mon Nov 29 2021 - 13:11:58 EST


Hi Rob,

On 09/11/21 11:49PM, Pratyush Yadav wrote:
> Hi,
>
> This series adds bindings for peripheral-specific SPI controller properties.
> See patch 1 for more info on the motivations behind this.
>
> This is the best approach that I came up with with my limited knowledge
> of JSON schema. It has some limitations that are mentioned in patch 1. I
> don't know of any better ways to model this. Suggestions are welcome!

Do you plan to take this series through your tree or should I poke Mark
about it?

>
> Changes in v3:
> - s/slave/peripheral/g
> - Drop the | on description.
> - Drop the compatible property.
>
> Changes in v2:
> - Move other subnode properties listed in spi-controller.yaml to
> spi-slave-props.yaml
> - Move the Cadence controller-specific properties out of
> spi-slave-props.yaml. They will be added in a separate file.
> - Add a reference to spi-slave-props.yaml in spi-controller.yaml.
> - Update description.
>
> Pratyush Yadav (3):
> spi: dt-bindings: add schema listing peripheral-specific properties
> spi: dt-bindings: cdns,qspi-nor: Move peripheral-specific properties
> out
> dt-bindings: mtd: spi-nor: Add a reference to
> spi-peripheral-props.yaml
>
> .../bindings/mtd/jedec,spi-nor.yaml | 3 +-
> .../spi/cdns,qspi-nor-peripheral-props.yaml | 42 +++++++++
> .../bindings/spi/cdns,qspi-nor.yaml | 33 -------
> .../bindings/spi/spi-controller.yaml | 69 +-------------
> .../bindings/spi/spi-peripheral-props.yaml | 89 +++++++++++++++++++
> 5 files changed, 135 insertions(+), 101 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml
> create mode 100644 Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>
> --
> 2.33.1.835.ge9e5ba39a7
>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.