Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes

[Peter Zijlstra]

On Mon, Nov 29, 2021 at 02:03:06PM +0100, Heiko Carstens wrote:
> v2:
> As requested by Greg KH: avoid negative logic and use uppercase defines.
> 
> v1:
> Create die and cluster cpu topology sysfs attributes only if an
> architecture makes uses of it, instead of creating them always for all
> architectures with bogus default values.
> Also change the book and drawer cpu topology macros so they match all
> all other topology macros.
> 
> v1: https://lore.kernel.org/lkml/20211128212221.1069726-1-hca@xxxxxxxxxxxxx/
> 
> Heiko Carstens (3):
>   topology/sysfs: export die attributes only if an architectures has support
>   topology/sysfs: export cluster attributes only if an architectures has support
>   topology/sysfs: rework book and drawer topology ifdefery
> 
>  Documentation/admin-guide/cputopology.rst | 33 +++++++++++------------
>  drivers/base/topology.c                   | 28 ++++++++++++++-----
>  include/linux/topology.h                  | 25 +++++++++++++++++
>  3 files changed, 62 insertions(+), 24 deletions(-)

Seems entirely reasonable to me,

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>