Re: [PATCH v3 3/3] regulator: da9121: Add DA914x support

[Mark Brown]

On Tue, Nov 23, 2021 at 11:27:58PM +0000, Adam Ward wrote:
> Signed-off-by: Adam Ward <Adam.Ward.opensource@xxxxxxxxxxx>

This doesn't build:

/mnt/kernel/drivers/regulator/da9121-regulator.c:571:8: error: 'DA9141_IDX_BUCK1' undeclared here (not in a function); did you mean 'DA9121_IDX_BUCK1'?
  571 |  .id = DA9141_IDX_BUCK1,
      |        ^~~~~~~~~~~~~~~~
      |        DA9121_IDX_BUCK1
/mnt/kernel/drivers/regulator/da9121-regulator.c:595:8: error: 'DA914X_IDX_BUCK1' undeclared here (not in a function); did you mean 'DA9121_IDX_BUCK1'?
  595 |  .id = DA914X_IDX_BUCK1,
      |        ^~~~~~~~~~~~~~~~
      |        DA9121_IDX_BUCK1
/mnt/kernel/drivers/regulator/da9121-regulator.c: In function 'da9121_check_device_type':
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:55: error: 'DA914X_DEVICE_ID' undeclared (first use in this function); did you mean 'DA914x_DEVICE_ID'?
  915 |  if ((device_id != DA9121_DEVICE_ID) && (device_id != DA914X_DEVICE_ID) {
      |                                                       ^~~~~~~~~~~~~~~~
      |                                                       DA914x_DEVICE_ID
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:55: note: each undeclared identifier is reported only once for each function it appears in
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:72: error: expected ')' before '{' token
  915 |  if ((device_id != DA9121_DEVICE_ID) && (device_id != DA914X_DEVICE_ID) {
      |     ~                                                                  ^~
      |                                                                        )
/mnt/kernel/drivers/regulator/da9121-regulator.c:996:1: error: expected expression before '}' token
  996 | }
      | ^
/mnt/kernel/drivers/regulator/da9121-regulator.c:912:3: error: label 'error' used but not defined
  912 |   goto error;
      |   ^~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:900:7: error: unused variable 'config_match' [-Werror=unused-variable]
  900 |  bool config_match = false;
      |       ^~~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:899:8: error: unused variable 'type' [-Werror=unused-variable]
  899 |  char *type;
      |        ^~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:898:18: error: unused variable 'variant_vrc' [-Werror=unused-variable]
  898 |  u8 variant_mrc, variant_vrc;
      |                  ^~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:898:5: error: unused variable 'variant_mrc' [-Werror=unused-variable]
  898 |  u8 variant_mrc, variant_vrc;
      |     ^~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:996:1: error: no return statement in function returning non-void [-Werror=return-type]
  996 | }
      | ^

Attachment: signature.asc
Description: PGP signature