Re: [PATCH v4 0/4] Add DTs for all Apple M1 (t8103) devices

From: Rob Herring
Date: Sun Nov 28 2021 - 18:30:15 EST


On Fri, Nov 26, 2021 at 12:51 AM Hector Martin <marcan@xxxxxxxxx> wrote:
>
> On 24/11/2021 07.49, Janne Grunau wrote:
> > Hej all,
> >
> > hopefully the last iteration of this series. Thanks for the reviews.
> >
> > Changes since v3:
> > - fixed typo in "arm64: dts: apple: t8103: Add cd321x nodes" commit
> > message
> > - fixed node order by address in t8103.dtsi
> > - removed clock-names property from i2c nodes
> > - renamed cd321x nodes to "usb-pd"
> > - added Reviewed-by and Acked-by tags
> >
> > This series is available as branch at
> > https://github.com/jannau/linux/tree/apple_m1/dt-for-5.17_v4
> >
> > For reference the message from v3:
> >
> > this series extends the device tree files and bindings to all current
> > Apple M1 devices. Specifically it adds DTs for following devices:
> > - MacBook Air (M1, 2020)
> > - Macbook Pro (13-inch, M1, 2020)
> > - iMac (24-inch, M1, 2021)
> >
> > It also adds i2c and cd321x devices nodes. Bindings and code changes for
> > those were merged for 5.16 without adding devices to the device tree.
> > Patches are include in a single series for dependencies
> >
> > Series depends for functionality and dtbs verification on
> > "[PATCH 0/3] Apple Arm patform device tree and bindings fixes".
> >
> >
> > Janne Grunau (4):
> > dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
> > arm64: dts: apple: Add missing M1 (t8103) devices
> > arm64: dts: apple: t8103: Add i2c nodes
> > arm64: dts: apple: t8103: Add cd321x nodes
> >
> > .../devicetree/bindings/arm/apple.yaml | 6 +-
> > arch/arm64/boot/dts/apple/Makefile | 4 +
> > arch/arm64/boot/dts/apple/t8103-j274.dts | 33 ++-----
> > arch/arm64/boot/dts/apple/t8103-j293.dts | 41 +++++++++
> > arch/arm64/boot/dts/apple/t8103-j313.dts | 33 +++++++
> > arch/arm64/boot/dts/apple/t8103-j456.dts | 59 +++++++++++++
> > arch/arm64/boot/dts/apple/t8103-j457.dts | 47 ++++++++++
> > arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 67 ++++++++++++++
> > arch/arm64/boot/dts/apple/t8103.dtsi | 87 +++++++++++++++++++
> > 9 files changed, 347 insertions(+), 30 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
> > create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
> > create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
> > create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
> > create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> >
> >
> > base-commit: fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
> > prerequisite-patch-id: 6827208d4389960d14555ee96768586179f9e8a7
> > prerequisite-patch-id: d5f23530f8cb99fbd9355f4bf0ccbaaca0cd6d7c
> > prerequisite-patch-id: 40ab5e8cc6dc6b5d44f075d8409f39966452bfb3
> >
>
> Acked-by: Hector Martin <marcan@xxxxxxxxx>
>
>
> Applied locally to asahi-soc/dt (with the #4 commit message fixed); that
> needs to be on top of the fixes branch, so I'll wait for Rob's ack on
> the binding change there before sending out the pulls. Thanks!

For just compatible additions, don't need to wait on me.

Rob