Re: [PATCH] ARM: dts: Fix timer regression for beagleboard revision c

From: Jarkko Nikula
Date: Sun Nov 28 2021 - 14:27:29 EST


On 25.11.2021 16.48, Tony Lindgren wrote:
> Commit e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> caused a timer regression for beagleboard revision c where the system
> clockevent stops working if omap3isp module is unloaded.
>
> Turns out we still have beagleboard revisions a-b4 capacitor c70 quirks
> applied that limit the usable timers for no good reason. This also affects
> the power management as we use the system clock instead of the 32k clock
> source.
>
> Let's fix the issue by adding a new omap3-beagle-ab4.dts for the old timer
> quirks. This allows us to remove the timer quirks for later beagleboard
> revisions. We also need to update the related timer quirk check for the
> correct compatible property.
>
> Fixes: e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/omap/omap.txt | 3 ++
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/omap3-beagle-ab4.dts | 47 +++++++++++++++++++
> arch/arm/boot/dts/omap3-beagle.dts | 33 -------------
> drivers/clocksource/timer-ti-dm-systimer.c | 2 +-
> 5 files changed, 52 insertions(+), 34 deletions(-)
> create mode 100644 arch/arm/boot/dts/omap3-beagle-ab4.dts
>
I trust Tony got this working since I lent the board for him to look at
this regression since our earlier remote attempts didn't find a working fix.

Jarkko