Re: [PATCH v6 2/3] dt-bindings: iio: add AD74413R

From: Jonathan Cameron
Date: Sat Nov 27 2021 - 13:54:01 EST


On Sat, 27 Nov 2021 02:23:26 +0100
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Fri, Nov 26, 2021 at 5:03 PM Cosmin Tanislav <demonsingur@xxxxxxxxx> wrote:
>
> > + adi,rsense-resistance-ohms:
> > + description:
> > + RSense resistance values in Ohms.
>
> This description is very terse. If it is existing for the same purpose as
> shunt-resistor-micro-ohms in
> Documentation/devicetree/bindings/iio/afe/current-sense-shunt.yaml
> then you should just recycle the standard binding
> shunt-resistor-micro-ohms instead of inventing this custom one.

Good point. I'd forgotten about that one. We had to make that generic
as a current sense shunt inherently doesn't have a vendor :)

Thanks Linus!

Jonathan
>
> Yours,
> Linus Walleij