Re: [PATCH net-next v3 1/4] dt-bindings: net: mscc,vsc7514-switch: convert txt bindings to yaml

From: Vladimir Oltean
Date: Fri Nov 26 2021 - 12:52:11 EST


On Fri, Nov 26, 2021 at 06:27:36PM +0100, Clément Léger wrote:
> + ethernet-ports:
> + type: object
> +
> + properties:
> + '#address-cells':
> + const: 1
> + '#size-cells':
> + const: 0
> +
> + additionalProperties: false
> +
> + patternProperties:
> + "^port@[0-9a-f]+$":
> + type: object
> + description: Ethernet ports handled by the switch
> +
> + $ref: ethernet-controller.yaml#
> +
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + description: Switch port number
> +
> + phy-handle: true
> +
> + phy-mode: true
> +
> + fixed-link: true
> +
> + mac-address: true
> +
> + required:
> + - reg
> +
> + oneOf:
> + - required:
> + - phy-handle
> + - phy-mode
> + - required:
> + - fixed-link

Are you practically saying that a phy-mode would not be required with
fixed-link? Because it still is...

> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - interrupt-names
> + - ethernet-ports