Re: [PATCH] crypto: siphash - use _unaligned version by default

From: Jason A. Donenfeld
Date: Fri Nov 26 2021 - 10:28:45 EST


On Fri, Nov 26, 2021 at 10:18 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> I have not tested this specific patch on all platforms, but I did
> extensive testing of the get_unaligned()/put_unaligned() helpers
> in my rewrite earlier this year[1], making sure that these are NOPs
> on all the important architectures, and that they prevent the use
> of trapping ldrd/ldm instructions on ARMv6/ARMv7.

If you're confident that the codegen doesn't change for ARMv8 and
x86{,_64}, then:

Reviewed-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

We should probably Cc stable@, right?

I'm preparing a patchset for DaveM's stable tree today, and I can take
this in that patchset.

Jason