Re: [Linux-stm32] [PATCH] dmaengine: stm32-mdma: Use bitfield helpers

From: Amelie DELAUNAY
Date: Fri Nov 26 2021 - 06:04:36 EST


Hi Geert,

Thanks for your patch.

On 11/22/21 4:54 PM, Geert Uytterhoeven wrote:
Use the FIELD_{GET,PREP}() helpers, instead of defining custom macros
implementing the same operations.

Signed-off-by: Geert Uytterhoeven<geert+renesas@xxxxxxxxx>


Reviewed-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>
Tested-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>

---
Compile-tested only.

See "[PATCH 00/17] Non-const bitfield helper conversions"
(https://lore.kernel.org/r/cover.1637592133.git.geert+renesas@xxxxxxxxx)
for background and more conversions.
---
drivers/dma/stm32-mdma.c | 74 +++++++++++++---------------------------
1 file changed, 23 insertions(+), 51 deletions(-)

Regards,
Amelie