Re: [PATCH] mm: kmemleak: alloc gray object for reserved region with direct map.

From: Catalin Marinas
Date: Thu Nov 25 2021 - 12:20:13 EST


On Tue, Nov 23, 2021 at 05:06:41PM +0800, Calvin Zhang wrote:
> Reserved regions with direct mapping may contain references to other
> regions. CMA region with fixed location is reserved without creating
> kmemleak_object for it.
>
> So add them as gray kmemleak objects.

Do you get any kmemleak false positives without this patch? It would be
good to include them in the commit message.

Without seeing a false positive caused by this, I'm not convinced it is
the right approach. You mentioned CMA but telling kmemleak about the
whole CMA region is a pretty big hammer. I'd rather add individual
kmemleak_alloc_*() calls in cma_alloc().

--
Catalin