Re: [PATCH 5/6] rcu/nocb: Allow empty "rcu_nocbs" kernel parameter

From: Andy Shevchenko
Date: Thu Nov 25 2021 - 06:41:56 EST


On Wed, Nov 24, 2021 at 08:41:32PM -0800, Yury Norov wrote:
> On Wed, Nov 24, 2021 at 04:47:20PM -0800, Paul E. McKenney wrote:
> > On Tue, Nov 23, 2021 at 01:37:07AM +0100, Frederic Weisbecker wrote:

...

> + if (!strncasecmp(str, "none", 4)) {
> + r->start = 0;
> + r->end = 0;
> + r->off = 0;
> + r->group_len = r->nbits;
> + str += 4;

> + goto out;

Side remark, I would make the name of the label a bit more verbose on what it's
going to be done there, "out_end_of_region:" or alike.

> + }

--
With Best Regards,
Andy Shevchenko