Re: [PATCH 2/2] arm64: dts: renesas: salvator-common: Merge hdmi0_con

From: Laurent Pinchart
Date: Wed Nov 24 2021 - 17:25:22 EST


Hi Kieran,

Thank you for the patch.

On Wed, Nov 24, 2021 at 03:28:15PM +0000, Kieran Bingham wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
>
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

This one I hadn't found earlier today, but it's equally valid.

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index bf37777dca31..6092dc4531ad 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -97,6 +97,7 @@ hdmi0-out {
>
> port {
> hdmi0_con: endpoint {
> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> };
> };
> };
> @@ -424,10 +425,6 @@ dw_hdmi0_snd_in: endpoint {
> };
> };
>
> -&hdmi0_con {
> - remote-endpoint = <&rcar_dw_hdmi0_out>;
> -};
> -
> #ifdef SOC_HAS_HDMI1
> &hdmi1 {
> status = "okay";

--
Regards,

Laurent Pinchart