Re: [PATCH v8 0/8] MIPS: JZ4780 and CI20 HDMI

From: H. Nikolaus Schaller
Date: Wed Nov 24 2021 - 11:48:27 EST


Hi Paul,

> Am 23.11.2021 um 21:44 schrieb H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>:
>
> Hi Paul,
>
>> Am 23.11.2021 um 21:12 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:
>>
>> Hi Nikolaus,
>>
>> I think if you can fix the last few things I commented on, and I get an ACK from Rob for the Device Tree related patches, then it will be ready to merge.
>
> Fine! Especially for finding the NULL regulator risk.
>
> Will do in the next days.
> For the unwedge pinmux I have to check if we need it at all.

No. It is only needed by the driver to take care of for a special potential hardware hickup.
The current code does nothing and I have removed it and everything still works as
before.

There remains only one question for a v9: can we store the (single) regulator reference
in a static variable or should we define a struct and allocate memory in patch 4/8?

BR and thanks,
Nikolaus