RE: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val'

From: G, GurucharanX
Date: Wed Nov 24 2021 - 08:04:08 EST




> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Jason Wang
> Sent: Sunday, November 14, 2021 11:32 AM
> To: kuba@xxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jason Wang
> <wangborong@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val'
>
> The variable used for return status in `igb_write_xmdio_reg' function is never
> changed and this function is just need return 0. Thus, the `ret_val' can be
> removed and return 0 at the end of the `igb_write_xmdio_reg' function.
>
> Signed-off-by: Jason Wang <wangborong@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Tested-by: Gurucharan G <gurucharanx.g@xxxxxxxxx> (A Contingent worker at Intel)