Re: [PATCH 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
From: Greg Kroah-Hartman
Date: Wed Nov 24 2021 - 02:09:25 EST
On Wed, Nov 24, 2021 at 02:57:38PM +0800, Cai Huoqing wrote:
> ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC,
> such as Allwinner R329 SOC.
> Add driver support for this AI accelerator here.
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/zynpu/Kconfig | 34 +
> drivers/staging/zynpu/Makefile | 7 +
> drivers/staging/zynpu/z1.c | 233 ++++++
> drivers/staging/zynpu/z2.c | 297 ++++++++
> drivers/staging/zynpu/zhouyi.h | 70 ++
> drivers/staging/zynpu/zhouyi_base.c | 71 ++
> drivers/staging/zynpu/zynpu.h | 252 +++++++
> drivers/staging/zynpu/zynpu_core.c | 254 +++++++
> drivers/staging/zynpu/zynpu_drv.c | 349 +++++++++
> drivers/staging/zynpu/zynpu_fops.c | 245 +++++++
> drivers/staging/zynpu/zynpu_io.c | 133 ++++
> drivers/staging/zynpu/zynpu_io.h | 119 ++++
> drivers/staging/zynpu/zynpu_irq.c | 123 ++++
> drivers/staging/zynpu/zynpu_irq.h | 85 +++
> drivers/staging/zynpu/zynpu_job_manager.c | 467 +++++++++++++
> drivers/staging/zynpu/zynpu_job_manager.h | 200 ++++++
> drivers/staging/zynpu/zynpu_mm.c | 704 +++++++++++++++++++
> drivers/staging/zynpu/zynpu_mm.h | 142 ++++
> drivers/staging/zynpu/zynpu_session.c | 817 ++++++++++++++++++++++
> drivers/staging/zynpu/zynpu_session.h | 283 ++++++++
> drivers/staging/zynpu/zynpu_sysfs.c | 205 ++++++
All code added to drivers/staging/ needs a TODO file that lists what
needs to be done to get it out of the staging directory.
You do not explain in this changelog text why this code needs to go
here, and why it could just not go into the "real" part of the kernel
instead. What is wrong with it that requires it to go here?
thanks,
greg k-h