Re: [PATCH] crypto: qce: fix uaf on qce_aead_register_one

From: Thara Gopinath
Date: Fri Nov 05 2021 - 17:08:54 EST




On 11/4/21 9:28 AM, Chengfeng Ye wrote:
Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.

Fixes: 9363efb4 ("crypto: qce - Add support for AEAD algorithms")
Signed-off-by: Chengfeng Ye <cyeaa@xxxxxxxxxxxxxx>


Acked-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx>

--
Warm Regards
Thara (She/Her/Hers)
---
drivers/crypto/qce/aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qce/aead.c b/drivers/crypto/qce/aead.c
index 290e2446a2f3..97a530171f07 100644
--- a/drivers/crypto/qce/aead.c
+++ b/drivers/crypto/qce/aead.c
@@ -802,8 +802,8 @@ static int qce_aead_register_one(const struct qce_aead_def *def, struct qce_devi
ret = crypto_register_aead(alg);
if (ret) {
- kfree(tmpl);
dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);
+ kfree(tmpl);
return ret;
}