Re: [PATCH 2/2] amba: Move of_amba_device_decode_irq() into amba_probe()

From: kernel test robot
Date: Fri Nov 05 2021 - 12:42:19 EST


Hi Kefeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20211105]
[cannot apply to v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Kefeng-Wang/amba-some-cleanup/20211104-174611
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7ddb58cb0ecae8e8b6181d736a87667cc9ab8389
config: arm-randconfig-r034-20211104 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/e7bfc31724b5810d3dade0f2b83635fec6aef601
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kefeng-Wang/amba-some-cleanup/20211104-174611
git checkout e7bfc31724b5810d3dade0f2b83635fec6aef601
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/amba/bus.c:186:9: error: implicit declaration of function 'of_amba_device_decode_irq' [-Werror,-Wimplicit-function-declaration]
ret = of_amba_device_decode_irq(dev);
^
drivers/amba/bus.c:375:12: error: static declaration of 'of_amba_device_decode_irq' follows non-static declaration
static int of_amba_device_decode_irq(struct amba_device *dev)
^
drivers/amba/bus.c:186:9: note: previous implicit declaration is here
ret = of_amba_device_decode_irq(dev);
^
2 errors generated.


vim +/of_amba_device_decode_irq +186 drivers/amba/bus.c

173
174 /*
175 * These are the device model conversion veneers; they convert the
176 * device model structures to our more specific structures.
177 */
178 static int amba_probe(struct device *dev)
179 {
180 struct amba_device *pcdev = to_amba_device(dev);
181 struct amba_driver *pcdrv = to_amba_driver(dev->driver);
182 const struct amba_id *id = amba_lookup(pcdrv->id_table, pcdev);
183 int ret;
184
185 do {
> 186 ret = of_amba_device_decode_irq(dev);
187 if (ret)
188 break;
189
190 ret = of_clk_set_defaults(dev->of_node, false);
191 if (ret < 0)
192 break;
193
194 ret = dev_pm_domain_attach(dev, true);
195 if (ret)
196 break;
197
198 ret = amba_get_enable_pclk(pcdev);
199 if (ret) {
200 dev_pm_domain_detach(dev, true);
201 break;
202 }
203
204 pm_runtime_get_noresume(dev);
205 pm_runtime_set_active(dev);
206 pm_runtime_enable(dev);
207
208 ret = pcdrv->probe(pcdev, id);
209 if (ret == 0)
210 break;
211
212 pm_runtime_disable(dev);
213 pm_runtime_set_suspended(dev);
214 pm_runtime_put_noidle(dev);
215
216 amba_put_disable_pclk(pcdev);
217 dev_pm_domain_detach(dev, true);
218 } while (0);
219
220 return ret;
221 }
222

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip