Re: [PATCH v1 1/5] tty: rpmsg: Assign returned id to a local variable

[Andy Shevchenko]

On Tue, Nov 2, 2021 at 3:21 PM Arnaud POULIQUEN
<arnaud.pouliquen@xxxxxxxxxxx> wrote:
> On 10/25/21 3:51 PM, Andy Shevchenko wrote:

...

> > +     cport->id = err;
>
> Set the cport->id to the err variable on success doesn't seem completely clean
> to me either.

I totally agree with you, that's why the
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=408a507996e4
 changed it.

-- 
With Best Regards,
Andy Shevchenko