Re: [PATCH v4 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt

From: Sean Nyekjaer
Date: Mon Nov 01 2021 - 04:46:30 EST


On Mon, Nov 01, 2021 at 08:38:24AM +0100, Boris Brezillon wrote:
> On Tue, 26 Oct 2021 07:55:48 +0200
> Sean Nyekjaer <sean@xxxxxxxxxx> wrote:
>
> > From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> >
> > The BBT scan logic use the MTD helpers before the MTD layer had a
> > chance to initialize the device, and that leads to issues when
> > accessing the uninitialized suspend lock. Let's temporarily set the
> > suspend/resume hooks to NULL to skip the lock acquire/release step.
> >
> > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
>
> I think I already mentioned this Fixes tag should not be there.
>

No, I didn't recall that, but nevermind :)

Hmm when ('mtd: core: protect access to MTD devices while in suspend')
is backported we want to live with the use before init of the rwsem?

/Sean