Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi
From: Martin Blumenstingl
Date: Fri Oct 15 2021 - 18:01:42 EST
Hi Neil,
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> This moves all the non-DW-HDMI code where it should be:
> an encoder in the drm/meson core driver.
>
> The bridge functions are copied as-is, except:
> - the encoder init uses the simple kms helper
> - the mode_set has been moved to atomic_enable()
> - debug prints are converted to dev_debg()
>
> For now the bridge attach flags is 0, DRM_BRIDGE_ATTACH_NO_CONNECTOR
> will be handled later.
>
> The meson dw-hdmi glue is slighly fixed to live without the
typo: slightly
> encoder in the same driver.
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
apart from that typo (please fix it up when applying the patch) this
is some great work!
it helps me a lot with HDMI support on the 32-bit SoCs
with that said:
Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>