Re: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq

From: Stephen Boyd
Date: Wed Oct 13 2021 - 15:35:25 EST


Quoting Fenglin Wu (2021-10-12 21:15:42)
>
> On 10/13/2021 1:46 AM, Stephen Boyd wrote:
> > Quoting Fenglin Wu (2021-09-16 23:32:56)
> >> From: Abhijeet Dharmapurikar <adharmap@xxxxxxxxxxxxxx>
> >>
> >> The cleanup_irq() was meant to clear and mask interrupts that were
> >> left enabled in the hardware but there was no interrupt handler
> >> registered for it. Add an error print when it gets invoked.
> > Why? Don't we get the genirq spurious irq message in this scenario?
>
> Thanks for reviewing the change.
>
> No, there is no existing message printed out in this special case ( IRQ
> fired for not registered interrupt).

Ah I see so the irq doesn't have a flow handler? Shouldn't you call
handle_bad_irq() in this case so we get a irq descriptor print?