[PATCH] scsi: sd: print write through due to no caching mode page as warning

From: Martin Kepplinger
Date: Wed Oct 13 2021 - 03:51:41 EST


For SD cardreaders it's extremely common not to find cache on disk.
The following error messages are thus very common and don't point
to a real error one could try to fix but rather describe how the disk
works:

sd 0:0:0:0: [sda] No Caching mode page found
sd 0:0:0:0: [sda] Assuming drive cache: write through

Print these messages as warnings instead of errors.

Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
---

hi Bart and all who it may concern,

I only resending the same patch I sent in January before:
https://lore.kernel.org/linux-scsi/20210122083000.32598-1-martin.kepplinger@xxxxxxx/

I like it more when messages printed as errors point to real problems that
need fixing.

thanks,
martin




drivers/scsi/sd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a646d27df681..33ea36b41136 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2793,7 +2793,8 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
}
}

- sd_first_printk(KERN_ERR, sdkp, "No Caching mode page found\n");
+ sd_first_printk(KERN_WARNING, sdkp,
+ "No Caching mode page found\n");
goto defaults;

Page_found:
@@ -2848,7 +2849,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
"Assuming drive cache: write back\n");
sdkp->WCE = 1;
} else {
- sd_first_printk(KERN_ERR, sdkp,
+ sd_first_printk(KERN_WARNING, sdkp,
"Assuming drive cache: write through\n");
sdkp->WCE = 0;
}
--
2.30.2