Re: [PATCH net-next 1/6] ether: add EtherType for proprietary Realtek protocols

[Vladimir Oltean]

On Tue, Oct 12, 2021 at 02:35:50PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> 
> Add a new EtherType ETH_P_REALTEK to the if_ether.h uapi header. The
> EtherType 0x8899 is used in a number of different protocols from Realtek
> Semiconductor Corp [1], so no general assumptions should be made when
> trying to decode such packets. Observed protocols include:
> 
>   0x1 - Realtek Remote Control protocol [2]
>   0x2 - Echo protocol [2]
>   0x3 - Loop detection protocol [2]
>   0x4 - RTL8365MB 4- and 8-byte switch CPU tag protocols [3]
>   0x9 - RTL8306 switch CPU tag protocol [4]
>   0xA - RTL8366RB switch CPU tag protocol [4]
> 
> [1] https://lore.kernel.org/netdev/CACRpkdYQthFgjwVzHyK3DeYUOdcYyWmdjDPG=Rf9B3VrJ12Rzg@xxxxxxxxxxxxxx/
> [2] https://www.wireshark.org/lists/ethereal-dev/200409/msg00090.html
> [3] https://lore.kernel.org/netdev/20210822193145.1312668-4-alvin@xxxxxxx/
> [4] https://lore.kernel.org/netdev/20200708122537.1341307-2-linus.walleij@xxxxxxxxxx/
> 
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>