Re: [PATCH] habanalabs: select CRC32

[Oded Gabbay]

On Mon, Oct 11, 2021 at 6:33 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Mon, Oct 11, 2021 at 5:14 PM Vegard Nossum <vegard.nossum@xxxxxxxxxx> wrote:
> >
> > Fix the following build/link error by adding a dependency on the CRC32
> > routines:
> >
> >   ld: drivers/misc/habanalabs/common/firmware_if.o: in function `hl_fw_dynamic_request_descriptor':
> >   firmware_if.c:(.text.unlikely+0xc89): undefined reference to `crc32_le'
> >
> > Signed-off-by: Vegard Nossum <vegard.nossum@xxxxxxxxxx>
>
> Patch looks good to me, I wonder how I never caught that with my own randconfig
> build testing. May I ask how you found it?
>
> Fixes: 8a43c83fec12 ("habanalabs: load boot fit to device")
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks!
Applied to my -next tree.
Oded