Re: [PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml
From: Krzysztof Kozlowski
Date: Sat Oct 09 2021 - 10:38:25 EST
On 09/10/2021 13:12, David Heidelberg wrote:
> Convert bindings for NXP PN544 NFC driver to YAML syntax.
>
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> .../bindings/net/nfc/nxp,pn544.yaml | 67 +++++++++++++++++++
> .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------
> 2 files changed, 67 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt
>
Hi,
Thanks for the patch. Please use get_maintainers.pl to get the list of
folks to Cc. You missed Rob. This is even weirder because you put him as
a maintainer...
> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> new file mode 100644
> index 000000000000..c44f5ee8e2c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nfc/nxp,pn544.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Semiconductors PN544 NFC Controller
> +
> +maintainers:
> + - Rob Herring <robh+dt@xxxxxxxxxx>
This should not be Rob but someone responsible for the driver. I see
there is no maintainers entry, so put there me:
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: nxp,pn544-i2c
> +
> + clock-frequency: true
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + enable-gpios:
> + description: Output GPIO pin used for enabling/disabling the PN544
> +
> + firmware-gpios:
> + description: Output GPIO pin used to enter firmware download mode
> +
> + pinctrl-names:
> + items:
> + - const: default
> +
> + pintctrl-0: true
Drop pinctrl, there is a typo here and this is already provided by the
schema.
> +
> +required:
> + - compatible
> + - clock-frequency
> + - reg
> + - interrupts
> + - enable-gpios
> + - firmware-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
Use 4-space indentation for the example. Easier to read.
> +
> + pn544@28 {
Nodes should have generic name, so "nfc".
> + compatible = "nxp,pn544-i2c";
Best regards,
Krzysztof