AW: (EXT) Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Add output-driver-strength property
From: Alexander Stein
Date: Fri Oct 08 2021 - 03:10:52 EST
On Mon, 05 Oct 2021 14:26:28 +0200, Rob Herring wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
> On Mon, 04 Oct 2021 13:15:28 +0200, Alexander Stein wrote:
> > From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> >
> > This property is for optimizing output voltage impedance and is
> > specific to each board.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > ---
> > I checked Micron and Macronix datasheets. Both have similar but not
> > identical supported values. Also the register locations are different.
> > For those reasons I decided to specify the Ohms value directly and let
> > the device specfic driver figure out if it is supported where to write
> > it to.
> > BTW: Are the Ohm values and the corresponding register bits standardized
> > somewhere?
> >
> > Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1536062
Thanks for pointing that out. I checked the amount of error messages related to
jedec,spi-nor.yaml before and after applying these patches using
> ARCH=arm64 make -j12 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml 2>&1 > /dev/null | wc -l
with all arm64 platforms enabled. There wasn't a change in the line count,
so I assume this new binding didn't cause them.
Best regards,
Alexander